Fix IntroduceConstant to place fields outside extension blocks#81340
Merged
CyrusNajmabadi merged 5 commits intomainfrom Nov 19, 2025
Merged
Fix IntroduceConstant to place fields outside extension blocks#81340CyrusNajmabadi merged 5 commits intomainfrom
CyrusNajmabadi merged 5 commits intomainfrom
Conversation
…ng type declaration Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
…tations Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix introduce constant IDE feature for extension blocks
Fix IntroduceConstant to place fields outside extension blocks
Nov 19, 2025
JoeRobich
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Introduce Constant" refactoring generated invalid code when invoked inside extension blocks, placing the constant within the extension block (illegal) and creating malformed qualified names like
extension(C).V.Changes
Core Fix (
CSharpIntroduceVariableService_IntroduceField.cs)GetAncestorOrThis<TypeDeclarationSyntax>()toGetAncestorsOrThis<TypeDeclarationSyntax>().FirstOrDefault(t => t is not ExtensionBlockDeclarationSyntax)ExtensionBlockDeclarationSyntax(which inherits fromTypeDeclarationSyntax) and finds the actual containing class/structusing System.Linq;Tests (
IntroduceVariableTests.cs)TestExtensionBlockIntroduceConstantandTestExtensionBlockIntroduceConstant_AllOccurrencesSkipdue to C# 14 extension block compilation issues in test infrastructureExample
Before (generates invalid code):
After:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.